Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

integration-docs: Update the SVN integration doc.#871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Niloth-p wants to merge1 commit intozulip:main
base:main
Choose a base branch
Loading
fromNiloth-p:docs/svn

Conversation

Niloth-p
Copy link
Contributor

@Niloth-pNiloth-p commentedJun 5, 2025
edited
Loading

Screenshots

SVN doc link
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (seecommit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Copy link

@laurynmmlaurynmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Niloth-p - Thanks for updating this doc! Overall, these updates look good. Posted a few review comments; let me know if you have any questions!

Copy link
ContributorAuthor

@Niloth-pNiloth-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the review! Updated as recommended.
I've not made any changes related to the existence of the target channel, as I'm unsure how to proceed.
I've switched to using backticks instead of double quotes for channel names, and added the prefix# in front of channel names (because that's the convention in the Help docs -example), based on your review comment on another doc PR.

Screenshot

image

@Niloth-p
Copy link
ContributorAuthor

I've switched to using bold formatting instead of backticks for channel names.

Screenshot

image

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@laurynmmlaurynmmlaurynmm left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Niloth-p@laurynmm@zulipbot

[8]ページ先頭

©2009-2025 Movatter.jp