Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork391
integration-docs: Update the screenshot path of Jira plugin#869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Niloth-p wants to merge1 commit intozulip:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It was previously using the path corresponding to the directoryname on `python-zulip-api` (`jira`). It's now updated to use the nameas used in the zulip/zulip repository.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It was previously using the path corresponding to the directory name on
python-zulip-api(jira). It's now updated to use the name as used in the zulip/zulip repository.This PR is intended to be merged only after#34782.
Follow-up: Once this PR is merged, we should remove the exclusion added to
test_integration_doc_endpointsinzulip/zulip'stest_docs.py.A previous version of the PR also updated Mercurial's
hg/001.png->mercurial/001.png, but I've since removed it, because of the hassle of tests failing whenever the images and docs are not in sync. So, I just addedimage_dirto point tohginintegrations.py.It is unavoidable for the Jira plugin though, because
jira/001.pngis being used by the Jira webhook integration. And there's a difference in the template format used, between the webhook and plugin integrations. We could consider using the same image for both the integ docs only if we test and upate them both to use the same message formats.Screenshots
Jira-plugin - before
Jira-plugin - after
How did you test this PR?
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (seecommit discipline).
Completed manual review and testing of the following: