Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bots: Fixed error handling for bot not found.#855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shiva-sai-824 wants to merge1 commit intozulip:main
base:main
Choose a base branch
Loading
fromshiva-sai-824:test-branch

Conversation

shiva-sai-824
Copy link

Fixes Fixed error handling for bot not found

How did you test this PR?

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (seecommit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

closes#489

@zulipbot
Copy link
Member

Hello@shiva-sai-824, it seems like you have referenced#489 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please rungit commit --amend in your command line client to amend your commit message description withFixes #489..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146Author: zulipbotDate:   Sat Mar 18 13:42:40 2017 -0700    pull requests: Check PR commits reference when issue is referenced.    Fixes #51.

To learn how to write a great commit message, please refer to ourguide.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bots: Fix error handling for bot not found.
2 participants
@shiva-sai-824@zulipbot

[8]ページ先頭

©2009-2025 Movatter.jp