Enhanced the do_api_query function with a retry mechanism (up to 3 attempts) for transient connection errors, configurable retry delays, and keep-alive headers. It resets the HTTP session on failures, differentiates between network errors and API errors, and maintains backward compatibility while improving reliability with optimized timeouts (90s for long-polling, 15s default).

Implement retry mechanism (up to 3 attempts) for transient connection errors
Add configurable retry delay and connection keep-alive headers
Reset HTTP session on connection failures to ensure clean reconnect
Differentiate between retryable network errors and API response errors
Set appropriate timeouts (90s for long-polling, 15s default otherwise)
Maintain backward compatibility while improving error resilience

Fixes:#761

How did you test this PR?

Self-review checklist

Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

Explains differences from previous plans (e.g., issue description).
Highlights technical choices and bugs encountered.
Calls out remaining decisions and concerns.
Automated tests verify logic where appropriate.

Individual commits are ready for review (seecommit discipline).

Each commit is a coherent idea.
Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

Visual appearance of the changes.
Responsiveness and internationalization.
Strings and tooltips.
End-to-end functionality of buttons, interactions and flows.
Corner cases, error conditions, and easily imagined bugs.

avijitdas126 added2 commits

February 5, 2025 19:42

Add API query reliability improvements with retries and keep-alive

52f1a88

Enhanced the do_api_query function with a retry mechanism (up to 3 attempts) for transient connection errors, configurable retry delays, and keep-alive headers. It resets the HTTP session on failures, differentiates between network errors and API errors, and maintains backward compatibility while improving reliability with optimized timeouts (90s for long-polling, 15s default).

fix: add whitespace and correct typos in __init__.py

b3dad03

Added missing whitespace for better readability and fixed minor typos in help_message and alert_move_message. Improved assertions and refactored redundant checks for cleaner test logic.

zulipbot added the size: M label

Feb 5, 2025

Copy link

Member

zulipbot commentedFeb 5, 2025

Hello@avijitdas126, it seems like you have referenced#761 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please rungit commit --amend in your command line client to amend your commit message description withFixes #761..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146Author: zulipbotDate:   Sat Mar 18 13:42:40 2017 -0700    pull requests: Check PR commits reference when issue is referenced.    Fixes #51.

To learn how to write a great commit message, please refer to ourguide.

1 similar comment