Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork391
rss-bot: Added a hash to the end of the feed_file#845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
anon1a7d wants to merge1 commit intozulip:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This allows for more than one feed per domain name (netloc).
Is there an issue this PR is solving? Please link it if so. |
There is not. It's something I noticed when I tried to use rss-bot to pull in two different feeds from a single domain. |
@Niloth-p can you review this? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for more than one feed per domain name (netloc). Previously, only a single feed could be associated with a domain name as the feed_file kept in the cache (data-dir) was simply the domain name (netloc). Using shake128, added an 8 digit hash (4 bytes in hex) of the full URL to the end of the feed_file name.
Now can support
https://example.com/site_one/feed.rssandhttps://example.com/site_two/feed.rss, etc.The files in the data-dir for these two URLs will be as follows.
How did you test this PR?
Ran the modified code manually from a tmp environment (including a unique data-dir). Confirmed cached feed_files were as expected. Messages successfully sent to test stream under proper topics.