Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork391
api: Implement GET /messages/{message_id}/read_receipts endpoint#821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
52fcb3a to2992ba1ComparePlease fix the typos in the function name -- these should all match the URLs in the API documentation. Check out theZulip commit message guidelines for more details. |
2992ba1 toc94f208Comparehi any updates on this@timabbott |
| return self.call_endpoint( | ||
| url=f"messages/{message_id}/read_receipts", | ||
| method="GET", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Our usual convention is to use the same names as the URL suffices onhttps://zulip.com/api/get-read-receipts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so should I change the function name to get_read_receipts, not sure if that is what you meant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes
Uh oh!
There was an error while loading.Please reload this page.
added a local function for getting a messages read recipt
referencehttps://zulip.com/api/get-read-receipts
proof of working: