Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork112
Comments
add build script parameter to set ZIG_OPTIMIZE_MODE#168
add build script parameter to set ZIG_OPTIMIZE_MODE#168nektro wants to merge 1 commit intoziglang:masterfrom
Conversation
| -Dstatic-llvm \ | ||
| -Doptimize=ReleaseFast \ | ||
| -Doptimize="$ZIG_OPTIMIZE_MODE" \ | ||
| -Dstrip \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One potential issue I see with this PR is this. I would assume that the motivation for distributing e.g. aReleaseSafe build of the compiler is that we can get useful stack traces when something goes wrong on the user's machine. It seems like-Dstrip undermines that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but andrew has expressed not wanting to add branching to this script, so that leaves the open question of if the-Dstrip should be removed unconditionally and-Dopotimize changed to ReleaseSafe always and the option removed in the wake of the acceptance of 15194
part 1/2 ofziglang/zig#15194
will make follow-up pr tohttps://github.com/ziglang/www.ziglang.org/blob/master/.github/workflows/build-tarballs.sh if/once this one is merged.