This repository was archived by the owner on Jan 21, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork25
Separate collection inputfilter validation#96
Closed
tigran-m-dev wants to merge4 commits intozfcampus:masterfromtigran-m-dev:separate_collection_inputfilter_validation
Closed
Separate collection inputfilter validation#96
tigran-m-dev wants to merge4 commits intozfcampus:masterfromtigran-m-dev:separate_collection_inputfilter_validation
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update fork master branch
…dation for Collection, if we have collection and entity like PATCH and PATCH list
coveralls commentedMay 21, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Member
michalbundyra commentedMay 22, 2018
@developer-devPHP We need tests for those changes. |
Author
tigran-m-dev commentedMay 22, 2018
@webimpress 'zf-content-validation' => ['Application\Controller\HelloWorld' => ['input_filter' =>'Application\Controller\HelloWorld\Validator','PUT' =>'Application\Controller\HelloWorld\UpdateValidator','PUT_COLLECTION' =>'Application\Controller\HelloWorld\UpdateCollectionValidator', ],], |
Fixed existing test testReturnsEarlyIfControllerServiceIsNotInConfig added ZFContentNegotiationParameterData
Author
tigran-m-dev commentedMay 29, 2018
@webimpress and@weierophinney |
weierophinney added a commit that referenced this pull requestMay 29, 2018
…tfilter_validationSeparate collection inputfilter validation
weierophinney added a commit that referenced this pull requestMay 29, 2018
weierophinney added a commit that referenced this pull requestMay 29, 2018
Member
weierophinney commentedMay 29, 2018
Thanks, @developer-devPHP; merged to develop for release with 1.5.0. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new functionality to allow create separate validation inputfilters if we have REST API. For example if we have update (PUT) and updateList (PUT collection). Before this changes we can't specify different validation for update and updateList because they are both PUT request, but now it is possible to just specify key PUT and PUT_COLLECTION