Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Separate collection inputfilter validation#96

Closed
tigran-m-dev wants to merge4 commits intozfcampus:masterfromtigran-m-dev:separate_collection_inputfilter_validation
Closed

Separate collection inputfilter validation#96

tigran-m-dev wants to merge4 commits intozfcampus:masterfromtigran-m-dev:separate_collection_inputfilter_validation

Conversation

@tigran-m-dev
Copy link

Added new functionality to allow create separate validation inputfilters if we have REST API. For example if we have update (PUT) and updateList (PUT collection). Before this changes we can't specify different validation for update and updateList because they are both PUT request, but now it is possible to just specify key PUT and PUT_COLLECTION

Tigran Mand others added2 commitsMay 16, 2018 16:54
…dation for Collection, if we have collection and entity like PATCH and PATCH list
@coveralls
Copy link

coveralls commentedMay 21, 2018
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 78.431% when pulling80b84fa on developer-devPHP:separate_collection_inputfilter_validation intoafa233a on zfcampus:master.

@michalbundyra
Copy link
Member

@developer-devPHP We need tests for those changes.

@tigran-m-dev
Copy link
Author

@webimpress
I just pasted example that you have in your doc and changed using this new functionality, which is under PUT_COLLECTION.
In this example we are using Update and Collection Update (List update)
And for each of methods we could specify different Validator

'zf-content-validation' => ['Application\Controller\HelloWorld' => ['input_filter' =>'Application\Controller\HelloWorld\Validator','PUT' =>'Application\Controller\HelloWorld\UpdateValidator','PUT_COLLECTION' =>'Application\Controller\HelloWorld\UpdateCollectionValidator',    ],],

Fixed existing test testReturnsEarlyIfControllerServiceIsNotInConfig added ZFContentNegotiationParameterData
@tigran-m-dev
Copy link
Author

@webimpress and@weierophinney
I added test for this new functionality. When you have a time please check and let me know your thoughts.
Thanks.

weierophinney added a commit that referenced this pull requestMay 29, 2018
…tfilter_validationSeparate collection inputfilter validation
weierophinney added a commit that referenced this pull requestMay 29, 2018
weierophinney added a commit that referenced this pull requestMay 29, 2018
@weierophinney
Copy link
Member

Thanks, @developer-devPHP; merged to develop for release with 1.5.0.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tigran-m-dev@coveralls@michalbundyra@weierophinney

[8]ページ先頭

©2009-2025 Movatter.jp