This repository was archived by the owner on Apr 28, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork18
Replace deprecated each()#29
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Merged
weierophinney added a commit that referenced this pull requestJan 25, 2018
Member
weierophinney commentedJan 25, 2018
Thanks,@Makinami; cherry-picked to master for a 2.6.2 release. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#28
Using of each() was also the cause of incompatibility with PHP7.2:
ErrorException: "The each() function is deprecated. This message will be suppressed on further calls"
Changing to foreach() and count() makes the package compatible with the latest PHP 7.2.1