This repository was archived by the owner on Jan 29, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork90
Provide PHP 7.2 support for zend-mvc 2.7 series#279
Merged
weierophinney merged 3 commits intozendframework:release-2.7fromweierophinney:hotfix/2.7-php-7.2-supportMay 2, 2018
Merged
Provide PHP 7.2 support for zend-mvc 2.7 series#279
weierophinney merged 3 commits intozendframework:release-2.7fromweierophinney:hotfix/2.7-php-7.2-supportMay 2, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
weierophinney commentedMay 2, 2018
- Updates dependencies to versions known to work with 2.7 when possible.
- Fixes a signature within the PluginManager
- Fixes a test asset signature
- Adds 7.1 and 7.2 jobs
cb15aa2 to7800a56Compare- Updates dependencies to versions known to work with 2.7 when possible.- Fixes a signature within the PluginManager- Fixes a test asset signature- Adds 7.1 and 7.2 jobs- Drops PHP 5.5 from the matrix Most dependencies _require_ 5.6 as a minimum supported version, and thus we cannot install dependencies as a result. It may still _work_ on 5.5, but if you're on 5.5, you don't care about 7.2 support.- Use latest possible version of PHPUnit in the v4 series.
…n detected`PluginManager` overrides the `get()` method, which has a differentsignature in v2 than in v3. Until PHP 7.2, this was not a problem;however, in 7.2, even optional values must follow the exact samesignature as the parent. As a result, we now need to vary theimplementations.This patch provides `AbstractPluginManager`, which contains the bulk of thelogic for implementing the `PluginManager`. It then introduces thefollowing:- `PluginManagerSM2`, which extends `AbstractPluginManager` and implements the zend-servicemanager v2 `get()` signature.- `PluginManagerSM3`, which extends `AbstractPluginManager` and implements the zend-servicemanager v3 `get()` signature.It removes the `PluginManager` class.It then adds a file-based autoloader that checks to see if`Zend\ServiceManager\PluginManagerInterface` exists. If it does, italiases `PluginManager` to `PluginManagerSM3`; otherwise, it aliases itto `PluginManagerSM2`.Additionally, this patch updates to zend-servicemanager 2.7.10, whichhas important fixes to how it handles creation options withInvokableFactory that are necessary here.
7800a56 to43cbba0CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.