- Notifications
You must be signed in to change notification settings - Fork40
added title in feed discovery as per document#63
Uh oh!
There was an error while loading.Please reload this page.
Conversation
added title in feed discovery as per documenthttps://docs.zendframework.com/zend-feed/find-feeds/
froschdesign commentedNov 15, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@rajjanorkar Btw. good catch! |
get title of link using nodeValue
rajjanorkar commentedNov 15, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@froschdesign I improved it to used nodeValue than title attribute not all links have title. edit : nodeValue does not make sense here as we are only searching for link tag so we have title attribute for that tag. I have added test created another pull request. (i am just editing here on github so was not able to combine both in one pull request (pull request 64) Thank you |
as we are looking for link tag only so title make more sense.
froschdesign commentedNov 15, 2017
@rajjanorkar |
added test
rajjanorkar commentedNov 15, 2017
@froschdesign added |
rajjanorkar commentedNov 15, 2017
@froschdesign could you please merge ? |
froschdesign commentedNov 16, 2017
@rajjanorkar |
rajjanorkar commentedDec 4, 2017
I think the process is so slow here... |
Ocramius commentedDec 4, 2017
Welcome to OSS 😑 |
rajjanorkar commentedDec 4, 2017
Thanks@Ocramius |
added title in feed discovery as per document
weierophinney commentedDec 4, 2017
Thanks,@rajjanorkar |
added title in feed discovery as per document
https://docs.zendframework.com/zend-feed/find-feeds/