Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

added title in feed discovery as per document#63

Merged
weierophinney merged 5 commits intozendframework:masterfromrajjanorkar:patch-7
Dec 4, 2017
Merged

added title in feed discovery as per document#63

weierophinney merged 5 commits intozendframework:masterfromrajjanorkar:patch-7
Dec 4, 2017

Conversation

@rajjanorkar
Copy link
Contributor

added title in feed discovery as per document
https://docs.zendframework.com/zend-feed/find-feeds/

@froschdesign
Copy link
Member

froschdesign commentedNov 15, 2017
edited
Loading

@rajjanorkar
If you create a new feature or find a bug, please add always an unit test. Thanks!

Btw. good catch!

get title of link using nodeValue
@rajjanorkar
Copy link
ContributorAuthor

rajjanorkar commentedNov 15, 2017
edited
Loading

Hi@froschdesign
I am really not that good in writing test, and for this scenario i tried but not getting idea.

I improved it to used nodeValue than title attribute not all links have title.

edit : nodeValue does not make sense here as we are only searching for link tag so we have title attribute for that tag.

I have added test created another pull request. (i am just editing here on github so was not able to combine both in one pull request (pull request 64)

Thank you

as we are looking for link tag only so title make more sense.
@froschdesign
Copy link
Member

@rajjanorkar
Add the unit test here.

added test
@rajjanorkar
Copy link
ContributorAuthor

@froschdesign added

@rajjanorkar
Copy link
ContributorAuthor

@froschdesign could you please merge ?

@froschdesign
Copy link
Member

@rajjanorkar
The workflow is not completed: a review is still needed.

@rajjanorkar
Copy link
ContributorAuthor

I think the process is so slow here...

@Ocramius
Copy link
Member

Welcome to OSS 😑

@rajjanorkar
Copy link
ContributorAuthor

Thanks@Ocramius

@weierophinneyweierophinney merged commit282df40 intozendframework:masterDec 4, 2017
weierophinney added a commit that referenced this pull requestDec 4, 2017
added title in feed discovery as per document
weierophinney added a commit that referenced this pull requestDec 4, 2017
weierophinney added a commit that referenced this pull requestDec 4, 2017
weierophinney added a commit that referenced this pull requestDec 4, 2017
@weierophinney
Copy link
Member

Thanks,@rajjanorkar

@froschdesignfroschdesign added this to the2.9.0 milestoneDec 5, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@OcramiusOcramiusOcramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rajjanorkar@froschdesign@Ocramius@weierophinney

[8]ページ先頭

©2009-2025 Movatter.jp