Nov 1, 2017 · Nov 10, 2017 · Nov 14, 2017 · Nov 14, 2017 · Nov 14, 2017 · Nov 14, 2017
diff --git a/src/Reader/StandaloneExtensionManager.php b/src/Reader/StandaloneExtensionManager.php
     * Remove an extension.
     *
     * @param string $name
     * @return bool
     */
    public function remove($name)
    {
        if (array_key_exists($name, $this->extensions)) {
            unset($this->extensions[$name]);
            return true;
        }
        return false;
        unset($this->extensions[$name]);
    }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,14 +65,9 @@ public function add($name, $class)
		* Remove an extension.
		*
		* @param string $name
		* @return bool
		*/
		public function remove($name)
		{
		if (array_key_exists($name, $this->extensions)) {
Copy link Member froschdesignNov 14, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Any reason, why this check is removed? Copy link Member XerkusNov 14, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. it is not needed. unset will work the same and there is no distinction between removing instance and noop. Copy link Member froschdesignNov 14, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @Xerkus You are right, it throws no error. Copy link ContributorAuthor SynchroNov 14, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It's because`unset` is a language construct, not a real function, and it doesn't care whether the thing you're unsetting exists or not. The check was only there before to set the return value.
		unset($this->extensions[$name]);
		return true;
		}
		return false;
		unset($this->extensions[$name]);
		}
		}