Do not cast request handlers implementing middleware to`RequestHandlerMiddleware`#646

Merged

weierophinney merged 1 commit intozendframework:masterfromweierophinney:hotfix/645-container-pipeline

Nov 8, 2018

Merged

Do not cast request handlers implementing middleware to`RequestHandlerMiddleware`#646

weierophinney merged 1 commit intozendframework:masterfromweierophinney:hotfix/645-container-pipeline

Nov 8, 2018

Conversation

Copy link

Member

weierophinney commentedNov 8, 2018

Per#645,MiddlewareContainer::get() was incorrectly casting middleware that also implementedRequestHandlerInterface toRequestHandlerMiddleware. This particularly affectedZend\Stratigility\MiddlewarePipe instances, as they implement both interfaces; if the last middleware in a pipeline called on the handler, users would then encounter a "pipeline exhausted" error, because it would be invoked as a handler, and thus have no reference to the application's pipeline.

This change verifies that the request handler does not also implementMiddlewareInterface before casting.

Fixes#645

Do not cast request handlers implementing middleware to `RequestHandl…

6bad82f

…erMiddleware`Per#645, `MiddlewareContainer::get()` was incorrectly castingmiddleware that also implemented `RequestHandlerInterface` to`RequestHandlerMiddleware`. This particularly affected`Zend\Stratigility\MiddlewarePipe` instances, as they implement bothinterfaces; if the last middleware in a pipeline called on the handler,users would then encounter a "pipeline exhausted" error, because itwould be invoked as a handler, and thus have no reference to theapplication's pipeline.This change verifies that the request handler does not also implement`MiddlewareInterface` before casting.