This repository was archived by the owner on Jan 29, 2020. It is now read-only.

zendframework/zend-codePublic archive

NotificationsYou must be signed in to change notification settings
Fork78
Star1.7k

fix Trying to access array offset on value of type nul (7.4)#172

Merged

michalbundyra merged 1 commit intozendframework:developfromremicollet:issue-php-74

Oct 5, 2019

Merged

fix Trying to access array offset on value of type nul (7.4)#172

michalbundyra merged 1 commit intozendframework:developfromremicollet:issue-php-74

Oct 5, 2019

Conversation

Copy link

Contributor

remicollet commentedSep 2, 2019

With 7.4.0beta4

There were 16 errors:1) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerHasClassInformationTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:712/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:652) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerHasMethodsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:712/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:893) ZendTest\Code\Scanner\ClassScannerTest::testHasMethodTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:846/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:1394) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerCanScanTraitsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:846/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:2075) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerCanGetTraitMethodsInGetMethodsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:746/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:709/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:2676) ZendTest\Code\Scanner\ClassScannerTest::testGetMethodsThrowsExceptionOnDuplicateMethodsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:746/work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:2937) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerHasMethodInformationTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:268) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsParametersTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:409) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsParameterScannerTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:4910) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerParsesClassNamesTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:6011) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsPropertyWithNoDefaultTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:7012) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsLineNumbersForMethodsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:7813) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsBodyMethodsTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:8714) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerMethodSignatureLatestOptionalParamHasParenthesesTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:9615) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerWorksWithSingleAbstractFunctionTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:11016) ZendTest\Code\Scanner\ParameterScannerTest::testParameterScannerHasParameterInformationTrying to access array offset on value of type null/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592/work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155/work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827/work/GIT/zend/zend-code/test/Scanner/ParameterScannerTest.php:22ERRORS!Tests: 996, Assertions: 1557, Errors: 16, Skipped: 9, Incomplete: 4.

fix Trying to access array offset on value of type nul (7.4)

7ddf144

michalbundyra reviewed

Sep 2, 2019

View reviewed changes

src/Scanner/MethodScanner.php

		$tokenContent =$token;
		$tokenLine =$tokenLine +substr_count(
		$lastTokenArray[1],
		$lastTokenArray[1] ??null,

Copy link

Member

michalbundyraSep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess it works, but I would prefer another fix: we shouldn't callsubstr_count if the first argument is null. This is not a problem now, but when we add strict types it becomes an issue, see:https://www.php.net/substr_count

Copy link

ContributorAuthor

remicolletSep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, this is a quick trivial fix (keeping same behavior)
But indeed, there is a logic error is this part of the code.

michalbundyra added the enhancement label

Oct 5, 2019

michalbundyra changed the base branch frommaster todevelop

October 5, 2019 22:37

michalbundyra added a commit that referenced this pull request

Oct 5, 2019

Merge pull request#172from remicollet/issue-php-74

555667e

fix Trying to access array offset on value of type nul (7.4)

michalbundyra added a commit that referenced this pull request

Oct 5, 2019

Adds CHANGELOG entry for#172

bdcaaa6

michalbundyra added a commit that referenced this pull request

Oct 5, 2019

Merge branch 'fix/172' into develop

f60a882

Close#172

michalbundyra merged commit7ddf144 intozendframework:develop

Oct 5, 2019

Copy link

Member

michalbundyra commentedOct 5, 2019

Thanks,@remicollet!

michalbundyra added this to the3.4.0 milestone

Oct 5, 2019

Labels

enhancement

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix Trying to access array offset on value of type nul (7.4)#172

fix Trying to access array offset on value of type nul (7.4)#172

Uh oh!

Conversation

remicollet commentedSep 2, 2019

Uh oh!

michalbundyraSep 2, 2019

Choose a reason for hiding this comment

Uh oh!

remicolletSep 2, 2019

Choose a reason for hiding this comment

Uh oh!

michalbundyra commentedOct 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants