- Notifications
You must be signed in to change notification settings - Fork43
Reports api#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Reports api#17
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -30,6 +30,8 @@ called: | |||
| $zencoder->inputs->details($input_id); | |||
| $zencoder->outputs->details($output_id); | |||
| $zencoder->notifications->parseIncoming(); | |||
| $zencoder->reports->vod($array); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like support for live reports is in this request - can you add a line for that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
added
To keep this consistent with the rest of the library, the casting to the different types of reports needs to be removed. The library is designed not to do much with the data back, to allow for flexibility on the API side in the future. |
I don't understand.. please can you explain with some code? |
glensc commentedMar 31, 2014
i think he means that you need to drop 'live', 'vod', 'all'. and just use 'details'-like call |
Removing the Zencoder CA chain cert and updating README
Bumping version to 2.2.0
jcart commentedJul 7, 2015
Was about to implement this since since we need to his the report api's. I am further unsure what you are rejecting this PR for? Please consider either being more descriptive in your responses. By the activity of this repository, I am doubtful anything will come from this. I am considering rewriting this library or forking it at this point. |
mmcc commentedJul 7, 2015
I'm really sorry this has languished for so long! This definitely should be added. @jcart Revisiting this, I think the reason this got stuck in purgatory was@mchristopher's comment:
The issue is that this PR knows too much about the API. If we change the API, we break the integration library, which isn't ideal considering we have quite a few supported libraries. The only thing that needs to change about the PR is simplifying that aspect, and we can pull this in.@cyriltata - mind updating it? Also it appears to need a rebase as well while you're in there. |
jcart commentedJul 7, 2015
@mmcc Thank you kindly for your response. That made things more clear to me. I will take another look at this tommorow then. Regards, John |
I forgot to go back into this as the above served the purpose but will try to do some update as recommended |
prebrov commentedDec 15, 2015
@MMC, any chance to review this PR? |
prebrov commentedDec 15, 2015
Sorry, meant@mmcc |
glensc commentedNov 6, 2019
This PR is superseded by#36 I've merged changes from master and squashed this PR to single commit for easier review. @mmcc@mchristopher@jcart@chriswarren or whoever is still active in this project ;) |
Add an interface to access zencoder reports over the api. In summary reports are accessed using
$zencoder->reports->{type}($params) where {type} can be one of 'live', 'vod', 'all'. $params is an optional associative array of parameters supporting by the reports api viz from, to grouping..