Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Post Formats support#10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jeffsebring wants to merge1 commit intozencoder:master
base:master
Choose a base branch
Loading
fromjeffsebring:master
Open

Added Post Formats support#10

jeffsebring wants to merge1 commit intozencoder:masterfromjeffsebring:master

Conversation

jeffsebring
Copy link

Allows for customization of 10 post formats using the WordPress API and CSS.

@homosaur
Copy link

Hey Jeff, if you are still interested in this, can you do a pull request on my branch at bytefair/eulerplate? I'm trying to maintain and update this theme. Thanks.

@jeffsebring
Copy link
Author

I don't have the repo anymore, but I would be happy to pull it down and make some edits. Is there anything else you might want added to it?

@homosaur
Copy link

well, I am looking to make some changes to bring some of the features of the very modern WordPress themes to Boilerplate. I'm only really trying to accomplish two things. One, to leave the CSS code completely alone. It should actually work like Boilerplate out of the box, just WordPressified. I may add some styles for things you can do inside the WYSIWYG post editor. I put in a few styles to handle floating images, but that's it. Two, to add some of the fancier new features of modern themes. Post types is a great example.

@jeffsebring
Copy link
Author

Themes handling custom post types and taxonomies, and other content
creation functions is considered a bad practice by many. The issue
being, if they change the theme, the content goes away unless the post
type is replicated in a plugin. At the same time, custom post types need
a theme that supports them to be useful.

I think the best way to do custom post types, is with a must use plugin.
I will eventually be writing some code to create them from my framework
through FTP, but this may be a bit much for a minimal starter theme like
HTML5 Boilerplate.

On 02/24/2012 06:28 AM, Paul Graham wrote:

well, I am looking to make some changes to bring some of the features of the very modern WordPress themes to Boilerplate. I'm only really trying to accomplish two things. One, to leave the CSS code completely alone. It should actually work like Boilerplate out of the box, just WordPressified. I may add some styles for things you can do inside the WYSIWYG post editor. I put in a few styles to handle floating images, but that's it. Two, to add some of the fancier new features of modern themes. Post types is a great example.


Reply to this email directly or view it on GitHub:
#10 (comment)

@homosaur
Copy link

That is a good point. I was thinking if it's in the default Wordpress install, like in Twenty Eleven, it could be included. You are probably right though, and that's why so far I've taken a conservative approach to adding anything. It's only with much gnashing of teeth that I added IDs to the page header and footer.

Sent from my iPad

On Feb 25, 2012, at 12:17 AM, JeffSebringreply@reply.github.com wrote:

Themes handling custom post types and taxonomies, and other content
creation functions is considered a bad practice by many. The issue
being, if they change the theme, the content goes away unless the post
type is replicated in a plugin. At the same time, custom post types need
a theme that supports them to be useful.

I think the best way to do custom post types, is with a must use plugin.
I will eventually be writing some code to create them from my framework
through FTP, but this may be a bit much for a minimal starter theme like
HTML5 Boilerplate.

On 02/24/2012 06:28 AM, Paul Graham wrote:

well, I am looking to make some changes to bring some of the features of the very modern WordPress themes to Boilerplate. I'm only really trying to accomplish two things. One, to leave the CSS code completely alone. It should actually work like Boilerplate out of the box, just WordPressified. I may add some styles for things you can do inside the WYSIWYG post editor. I put in a few styles to handle floating images, but that's it. Two, to add some of the fancier new features of modern themes. Post types is a great example.


Reply to this email directly or view it on GitHub:
#10 (comment)


Reply to this email directly or view it on GitHub:
#10 (comment)

@homosaur
Copy link

What we maybe could do is put the code in and leave it commented out by
default. It would actually be a very Boilerplate thing to do. I'm thinking
if the default theme has a feature, it would be okay to add it, if only in
comments. That way if you moved from default to an Eulerplate based theme,
you'd still have the features of a default install a couple deletes away.
On Feb 25, 2012 12:23 AM, "Paul Graham"homosaur@gmail.com wrote:

That is a good point. I was thinking if it's in the default Wordpress
install, like in Twenty Eleven, it could be included. You are probably
right though, and that's why so far I've taken a conservative approach to
adding anything. It's only with much gnashing of teeth that I added IDs to
the page header and footer.

Sent from my iPad

On Feb 25, 2012, at 12:17 AM, Jeff Sebring<
reply@reply.github.com>
wrote:

Themes handling custom post types and taxonomies, and other content
creation functions is considered a bad practice by many. The issue
being, if they change the theme, the content goes away unless the post
type is replicated in a plugin. At the same time, custom post types need
a theme that supports them to be useful.

I think the best way to do custom post types, is with a must use plugin.
I will eventually be writing some code to create them from my framework
through FTP, but this may be a bit much for a minimal starter theme like
HTML5 Boilerplate.

On 02/24/2012 06:28 AM, Paul Graham wrote:

well, I am looking to make some changes to bring some of the features
of the very modern WordPress themes to Boilerplate. I'm only really trying
to accomplish two things. One, to leave the CSS code completely alone. It
should actually work like Boilerplate out of the box, just WordPressified.
I may add some styles for things you can do inside the WYSIWYG post editor.
I put in a few styles to handle floating images, but that's it. Two, to add
some of the fancier new features of modern themes. Post types is a great
example.


Reply to this email directly or view it on GitHub:

#10 (comment)


Reply to this email directly or view it on GitHub:

#10 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jeffsebring@homosaur

[8]ページ先頭

©2009-2025 Movatter.jp