- Notifications
You must be signed in to change notification settings - Fork1
Upgrade Jackson dep in castlabs-java-api#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stuarthicks left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't see any feedback on this PR from CI, have you checked that the build still works as expected?
pom.xml Outdated
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.5.4</version> | ||
| <version>2.7.9.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's a newer version than this,2.9.8... any reason to pick this version specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And in fact... I can't find a version2.7.9.4 in maven central... so I'm assuming this builddoesn't work.
elbadawimustafaApr 10, 2019 • edited by stuarthicks
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by stuarthicks
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I used2.7.9.4 because it was in the ticket.
it builds fine locally but doesn't do on circle because this repo is on circle v1 which is no longer supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Interesting... I wonder why maven central doesn't show that version. I'd like to figure that out before we accept this change.
Also,@thomshutt left a comment on the ticket earlier today mentioning circle v2... I think we should do that in this PR and get that green tick from Circle back again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Cool, we can have a look tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Weird, confirmed as well that 2.7.9.4 builds. I wonder why I can't find it on search.maven.org 🙃.
Definitely tomorrow-me's problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We have the green ticket from Circle now and I've bumped jackson-databind to 2.9.8
No description provided.