- Notifications
You must be signed in to change notification settings - Fork1
Added support for linking accounts to sub-merchants#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| try (finalCloseableHttpResponsehttpResponse =httpclient.execute(httpRequest)) { | ||
| finalintstatusCode =httpResponse.getStatusLine().getStatusCode(); | ||
| if (statusCode <200 ||statusCode >=300) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd be surprised iforg.apache.http didn't have constants for these somewhere. Could we double-check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Switched to just checking for the 204 that Castlabs currently return on success
| * Add a sub merchant account to Castlabs. | ||
| * | ||
| * @param request Request parameters to pass to Castlabs | ||
| * @param requestRequest parameters to pass to Castlabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is your IDE adding the whitespace here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep, it lines it up with the@param on the line below
| } | ||
| } | ||
| privateHttpPostcreateHttpPostRequest(finalStringuri,finalObjectbody)throwsJsonProcessingException,UnsupportedEncodingException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I approve of this refactoring 👍
stuarthicks left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
No description provided.