Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork366
set up benchmarks with asv#3554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
closes#337 |
there might be better / alternative tools than asv for this purpose, likecodspeed. I picked asv because that's what numpy is using, but the choice of tool is definitely a degree of freedom here. |
IMO it depends on your goals. If you want to run comparisons between two branches locally then asv can be fine. If you want the benchmarks integrated into CI then codspeed would work better. I personally prefer codspeed because I've found it easier to integrate with existing tests rather than needing separate a benchmarking setup. |
generally I'm hearing more enthusiasm for something like codspeed instead of asv, and the argument in favor of benchmarks being integrated with our tests is persuasive to me, so I'm going to close this |
Sets up very basic benchmarks usingasv.
I don't want to write up all of the benchmarks we need in this PR. this is just setting up the basic infrastructure.