Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor fixes for zarr.codecs.numcodecs#3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-v-b merged 3 commits intozarr-developers:mainfromK-Meech:km/numcodecs-fixes
Sep 15, 2025

Conversation

@K-Meech
Copy link
Contributor

Closes#3458

This PR addresses two minor issues:

  • gzip still imports the oldnumcodecs.zarr3 implementation (see the issue:numcodecs.gzip is not configured in the config #3458 for more details)
  • The example at the top ofzarr.codecs.numcodecs._codecs throws an error when run:module 'zarr.codecs.numcodecs' has no attribute 'zarr3'

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented indocs/user-guide/*.rst
  • Changes documented as a new file inchanges/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelSep 15, 2025
@d-v-b
Copy link
Contributor

yay!

@d-v-b
Copy link
Contributor

i think we can skip the release notes here

@K-Meech
Copy link
ContributorAuthor

@d-v-b I've fixed the failing tests locally, but there's still a failure in the CI (only for python=3.11 / np=1.26 env). It seems to be from an un-related test functiontests/test_sync.py::test_sync_timeout. Any idea what the issue is here?

@d-v-b
Copy link
Contributor

@d-v-b I've fixed the failing tests locally, but there's still a failure in the CI (only for python=3.11 / np=1.26 env). It seems to be from an un-related test functiontests/test_sync.py::test_sync_timeout. Any idea what the issue is here?

that's a flaky test that depends on the runtime of a function. it usually works if you trigger a re-run, but we can also ignore the failure

K-Meech reacted with thumbs up emoji

@d-v-bd-v-benabled auto-merge (squash)September 15, 2025 16:07
@d-v-bd-v-b merged commit62d1a6a intozarr-developers:mainSep 15, 2025
64 of 69 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-v-bd-v-bd-v-b approved these changes

Assignees

No one assigned

Labels

needs release notesAutomatically applied to PRs which haven't added release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

numcodecs.gzip is not configured in the config

2 participants

@K-Meech@d-v-b

[8]ページ先頭

©2009-2025 Movatter.jp