Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ensure absolute paths work with consolidate metadata#3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-v-b merged 3 commits intozarr-developers:mainfromshoyer:consolidated-subgroup
Sep 3, 2025

Conversation

@shoyer
Copy link
Contributor

@shoyershoyer commentedSep 2, 2025•
edited
Loading

This ensures syntax likeroot['/subgroup'] works equivalently toroot['subgroup'] when using consolidated metadata.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Changes documented as a new file inchanges/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelSep 2, 2025
@codecov
Copy link

codecovbot commentedSep 2, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (6c04c82) to head (baec8c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #3428   +/-   ##=======================================  Coverage   94.92%   94.92%           =======================================  Files          79       79             Lines        9503     9503           =======================================  Hits         9021     9021             Misses        482      482
Files with missing linesCoverage Δ
src/zarr/core/group.py95.06% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@d-v-bd-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks! we just need some release notes and then this is good to go.

@github-actionsgithub-actionsbot removed the needs release notesAutomatically applied to PRs which haven't added release notes labelSep 2, 2025
shoyer added a commit to shoyer/xarray that referenced this pull requestSep 2, 2025
Writing to zarr with `mode='r+'` was broken bypydata#10625, due to a Zarrbug (zarr-developers/zarr-python#3428). Thisadd a work-around that works on older versions of Zarr.The PR that introduced this bug has not yet appeared in an xarrayrelease, so there's no need for a release note.
@shoyer
Copy link
ContributorAuthor

Should be good to go now

@d-v-bd-v-b merged commit00e7814 intozarr-developers:mainSep 3, 2025
31 checks passed
@d-v-b
Copy link
Contributor

thanks@shoyer!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-v-bd-v-bd-v-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shoyer@d-v-b
[8]ページ先頭
©2009-2025 Movatter.jp