Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork366
chore/unformatted exceptions#3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ore/unformatted-exceptions
codecovbot commentedAug 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3403 +/- ##==========================================+ Coverage 94.89% 94.92% +0.03%========================================== Files 79 79 Lines 9501 9503 +2 ==========================================+ Hits 9016 9021 +5+ Misses 485 482 -3
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
…-b/zarr-python into chore/unformatted-exceptions
This looks good, I think a test just needs updating for my suggestion of a more informative error message. I'll approve once the tests pass |
@maxrjones tests are green |
b8dbf56 intozarr-developers:mainUh oh!
There was an error while loading.Please reload this page.
This pr addresses#3402 by allowing all of the zarr-specific exceptions take a single argument, which will be treated as a pre-formatted message. The old behavior, in which an exception would take multiple arguments and use them to format a canned message, is still available by passing in multiple arguments. I don't know how to deprecate this visibly, but I also suspect the API of
zarr.errorsis not a load-bearing member for many downstream projects.While changing the exceptions in
zarr.errors, I found more exceptions defined inzarr.core.indexing. I moved those definitions tozarr.errors, because all our errors should be defined in one place, barring a strong reason otherwise. Had all the errors been defined in place, I wouldn't have needed to use a text search to discover the additional errors inzarr.core.indexing.