Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore/unformatted exceptions#3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@d-v-b
Copy link
Contributor

This pr addresses#3402 by allowing all of the zarr-specific exceptions take a single argument, which will be treated as a pre-formatted message. The old behavior, in which an exception would take multiple arguments and use them to format a canned message, is still available by passing in multiple arguments. I don't know how to deprecate this visibly, but I also suspect the API ofzarr.errors is not a load-bearing member for many downstream projects.

While changing the exceptions inzarr.errors, I found more exceptions defined inzarr.core.indexing. I moved those definitions tozarr.errors, because all our errors should be defined in one place, barring a strong reason otherwise. Had all the errors been defined in place, I wouldn't have needed to use a text search to discover the additional errors inzarr.core.indexing.

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelAug 25, 2025
@d-v-bd-v-b requested a review froma teamAugust 25, 2025 08:22
@codecov
Copy link

codecovbot commentedAug 25, 2025
edited
Loading

Codecov Report

❌ Patch coverage is92.45283% with4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.92%. Comparing base (6d4b5e7) to head (fd6c3b2).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
src/zarr/core/indexing.py87.50%2 Missing⚠️
src/zarr/storage/_common.py66.66%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3403      +/-   ##==========================================+ Coverage   94.89%   94.92%   +0.03%==========================================  Files          79       79                Lines        9501     9503       +2     ==========================================+ Hits         9016     9021       +5+ Misses        485      482       -3
Files with missing linesCoverage Δ
src/zarr/api/asynchronous.py90.03% <100.00%> (+0.06%)⬆️
src/zarr/core/array.py97.44% <100.00%> (+<0.01%)⬆️
src/zarr/core/group.py95.06% <100.00%> (+0.02%)⬆️
src/zarr/core/metadata/v3.py90.15% <100.00%> (+0.10%)⬆️
src/zarr/errors.py100.00% <100.00%> (+12.50%)⬆️
src/zarr/core/indexing.py96.26% <87.50%> (-0.15%)⬇️
src/zarr/storage/_common.py92.47% <66.66%> (-0.43%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actionsgithub-actionsbot removed the needs release notesAutomatically applied to PRs which haven't added release notes labelAug 25, 2025
@maxrjones
Copy link
Member

This looks good, I think a test just needs updating for my suggestion of a more informative error message. I'll approve once the tests pass

@d-v-b
Copy link
ContributorAuthor

@maxrjones tests are green

@d-v-bd-v-b merged commitb8dbf56 intozarr-developers:mainAug 29, 2025
31 checks passed
@d-v-bd-v-b deleted the chore/unformatted-exceptions branchAugust 29, 2025 19:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@maxrjonesmaxrjonesmaxrjones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-v-b@maxrjones

[8]ページ先頭

©2009-2025 Movatter.jp