Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix:*-like creation routines take kwargs#2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-v-b merged 25 commits intozarr-developers:mainfromd-v-b:fix/zeros-like-takes-kwargs
Sep 17, 2025

Conversation

@d-v-b
Copy link
Contributor

In main, array creation routines that take an existing array, likefull_like,zeros_like, etc, don't allow users to override certain array properties (like shape and dtype) via keyword arguments. E.g.,full_like(arr, shape=(10,)) will ignore theshape keyword argument and produce an array with the same shape asarr.

This PR makes these array creation routines sensitive to keyword arguments likeshape,dtype,chunks, etc.

closes#2989

@github-actionsgithub-actionsbot added the needs release notesAutomatically applied to PRs which haven't added release notes labelApr 17, 2025
@github-actionsgithub-actionsbot removed the needs release notesAutomatically applied to PRs which haven't added release notes labelApr 17, 2025
@d-v-bd-v-b requested a review fromjhammanApril 20, 2025 19:34
@d-v-b
Copy link
ContributorAuthor

requesting review from@jhamman since I think you touched this code most recently

@d-v-b
Copy link
ContributorAuthor

our upstream tests are failing because fsspec and s3fs tips are incompatible. this failure has nothing to do with this PR.

@d-v-bd-v-b requested a review fromTomAugspurgerMay 23, 2025 12:02
@d-v-bd-v-benabled auto-merge (squash)September 17, 2025 21:05
@d-v-bd-v-b merged commit62551c7 intozarr-developers:mainSep 17, 2025
29 checks passed
@codecov
Copy link

codecovbot commentedSep 17, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is64.28571% with10 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.24%. Comparing base (6805332) to head (4186442).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
src/zarr/api/asynchronous.py64.28%10 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2992      +/-   ##==========================================+ Coverage   61.23%   61.24%   +0.01%==========================================  Files          83       83                Lines        9897     9907      +10     ==========================================+ Hits         6060     6068       +8- Misses       3837     3839       +2
Files with missing linesCoverage Δ
src/zarr/api/asynchronous.py72.20% <64.28%> (+0.27%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-bd-v-b deleted the fix/zeros-like-takes-kwargs branchSeptember 17, 2025 22:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jhammanjhammanjhamman approved these changes

@TomAugspurgerTomAugspurgerAwaiting requested review from TomAugspurger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v3] Functionzeros_like ignores overrides in keyword arguments (e.g.chunks,dtype).

3 participants

@d-v-b@TomAugspurger@jhamman
[8]ページ先頭
©2009-2025 Movatter.jp