Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork366
Clean up warning filters in tests#2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
596d674 tod157e9cCompared6d8c91 to2b91d6eCompareWould be good to get this in ASAP to avoid more warnings in the tests! |
d-v-b approved these changesApr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for this@dstansby!
50abf3d intozarr-developers:main 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
d-v-b pushed a commit to d-v-b/zarr-python that referenced this pull requestApr 20, 2025
* Clean up warning filters in tests* Ignore some more warnings* Ignore some more warnings* Ignore boto3 deprecation warning* Ignore unclosed client warning* Filter another fsspec warning* Ignore zip warning* Filter warning in test_stateful* pre-commit fixes* Filter warning in test_wrapper* Filter warning in memorystore* Close pool in multiprocessing test* pre-commit fixes* Filter two more warnings* Filter another warning* Filter more warnings* Add changelog* Ignore unclosed client sessions* Put back dtype filter* Make client session filter better
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I'm hoping to clean up the warning filters in this PR, starting with making them all error, and then either fix the warnings that come up or add them back to the filters. Opening because I noticed some deprecation warnings in our tests that should probably either be explicitly caught or the code fixed.
Fixes#2968