In 2.x,Group.create was used to create an array in the Group.

I slightly preferfrom_* for alternative constructors anyway, so maybe this is a strict improvement and not just a compatibility shim?

I agree that this needs to change in order to avoid confusion.

i'm also a fan offrom_X, andfrom_store seems good

We can vendor and usehttps://github.com/scikit-learn/scikit-learn/blob/e87b32a81c70abed8f2e97483758eb64df8255e9/sklearn/utils/validation.py#L32 to deprecate positional arguments. At least of xarray, it passed juststore as a positional argument, but deprecating these doesn't feel like too much work.

I like this suggestion. Should we do it in 2.18.3 or 3.0 though?

I don't have a strong preference here.

IMO, calendar time is more meaningful than version numbers for giving projects time to adapt to changes. So I'd say deprecate it in 3.0, as long as we don't have a hard stance on requiring keyword only for these APIs in 3.0

Should we deprecate this, and encourage users to dogroup.store_path.store?

github is flagging this conversation as outdated, but regardless: I agree that we should just have eithergroup.store orgroup.store_path.store. But I'm not a huge fan ofstore_path actually, so I'd actually favor deprecatingthat, and going back to v2 behavior where arrays / groups have astore attribute, and the store has apath attribute. But this is just my personal opinion, built from findinggroup.store_path.store a little weird.

Same question as store.

Should probably add this toAsyncGroup too and update this implementation.

in principle we could test this functionality for other stores. but I also think testing the full product of[array / group features * stores] is excessive. I guess as long as we are confident that we are densely testing the core store APIs across store types, then it's fine to just test something derived from the store APIs on a single store.

I think that in this case it's probably OK, since the test here is focused on the behavior of Attributes. This happens to require a reference to a Group (which requires a Store) but hopefully that interface is sufficiently covered by other tests.