Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Deprecate and disable core break extension#8363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aryangupta701 wants to merge5 commits intozaproxy:main
base:main
Choose a base branch
Loading
fromaryangupta701:brk-deprecation

Conversation

@aryangupta701
Copy link
Contributor

Fixes#8153

@aryangupta701
Copy link
ContributorAuthor

oh wait, I think I did something wrong. I didn't understand how spider was deprecated from the corehttps://github.com/zaproxy/zaproxy/pull/7335/files#. Are we keeping the spider in the core in private/protected mode so that it is not accessible from outside?

@thc202
Copy link
Member

The classes should be kept but deprecated and the extension is no longer added to theCoreFunctionality.

@thc202thc202 changed the titlechore: brk deprecationDeprecate and disable core break extensionFeb 27, 2024
@aryangupta701aryangupta701force-pushed thebrk-deprecation branch 3 times, most recently froma471197 to054717eCompareMarch 14, 2024 23:26
@aryangupta701
Copy link
ContributorAuthor

ready for review

@aryangupta701aryangupta701force-pushed thebrk-deprecation branch 3 times, most recently from04412c3 to945c8adCompareMarch 14, 2024 23:44
@aryangupta701aryangupta701force-pushed thebrk-deprecation branch 2 times, most recently from0abefe7 toe6cc1e4CompareMarch 16, 2024 23:22
@aryangupta701
Copy link
ContributorAuthor

ready for review

@thc202
Copy link
Member

Also, please include the break add-on in the weekly:

@thc202
Copy link
Member

thc202 commentedMar 22, 2024•
edited
Loading

This will now have to wait forzaproxy/zap-extensions#5213 (and follow up changes in other add-ons).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@thc202thc202thc202 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move break functionality to an add-on

2 participants

@aryangupta701@thc202
[8]ページ先頭
©2009-2025 Movatter.jp