Be good to add tests.

In addition, a performance hit compiling a regex repeatedly was found and fixed.

Do you have numbers? (Just curiosity.)

In addition, a performance hit compiling a regex repeatedly was found and fixed.

Do you have numbers? (Just curiosity.)

Nothing big. I think I read the wrong number, but still good practice to pre-compile.

Be good to add tests.

refreshScope() is only called when the view is initialized. I didn't see anything that would mock that inSessionUnitTest. Ideas?

Nothing big. I think I read the wrong number, but still good practice to pre-compile.

Thank you. Agreed.

refreshScope() is only called when the view is initialized. I didn't see anything that would mock that inSessionUnitTest. Ideas?

You can mock theView, though given the EDT is in use probably something to go undersrc/testGui/.

It looks like the only way to verifyrefreshScope() is called is to check for side effects in the site tree unless the method is made package-private. How do you feel about that?

It looks like the only way to verifyrefreshScope() is called is to check for side effects in the site tree unless the method is made package-private. How do you feel about that?

MakingrefreshScope() package private would make adding the tests easier. Adding tests intotestGui/ looks like a significant copy and paste of setup code fromtest/ totestGui/ . I don't want to do that work if it's not desired. Can someone comment on direction?

recheck

Is this old enough that it needs rebase to properly pickup CLA?

No.

#8205 (comment)

Exposing the method would not make much difference as we can't still tell if it's called or not, we should check that throughsessionScopeChanged instead.

Regarding the duplication, that should not be needed astestGui should have visibility intotest (if not that should be changed rather than duplicate).

Regarding the duplication, that should not be needed astestGui should have visibility intotest (if not that should be changed rather than duplicate).

As far as I can tell testGui does not have visibility into test. IDEA doesn't recognizetestGui as a source folder either, but thetestGui task is recognized. I can't figure out how to gettestGui to depend on the classpath oftest. I've tried:

configurations {    testGuiImplementation {        extendsFrom(testImplementation.get())    }    testGuiRuntimeOnly {        extendsFrom(testRuntimeOnly.get())    }}

but it doesn't help. If you know, could you post the gradle code?