Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Breakpoints.#7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Keindel wants to merge1 commit intozaproxy:main
base:main
Choose a base branch
Loading
fromKeindel:breaks-pr
Open

Breakpoints.#7875

Keindel wants to merge1 commit intozaproxy:mainfromKeindel:breaks-pr

Conversation

@Keindel
Copy link

@KeindelKeindel commentedMay 23, 2023
edited
Loading

In Break add/edit dialog String Field has been splitted into multiple fields: Protocol, Host, Path, Query.

Add request and/or response choice in breaks: choice of break activation on-request and/or on-response is now available.

Add break persisting. Breaks in UI are now consistent with session DB.

Silencegod, naiad09, MrShmiTT, vtlgnv, MissiaL, amashq, UncleSema, DmitriyVodyanov, Furrial, Mortished, and 20 more reacted with thumbs up emojinaiad09, vtlgnv, DmitriyVodyanov, Mirontsev, mrhyman, khda91, annasenina, mlopatina, MaxFrodo, rs16w, and 8 more reacted with heart emojidzotovwork, ikalinin1, and tnagmetulla reacted with rocket emoji
@kingthorin
Copy link
Member

Also I believe there's a JSON View available via the Marketplace.

thc202 reacted with thumbs up emojiKeindel reacted with eyes emoji

@kingthorin
Copy link
Member

@thc202thc202 changed the titleBreakpoints.[WIP] Breakpoints.May 23, 2023
@KeindelKeindelforce-pushed thebreaks-pr branch 3 times, most recently frome5fbcc6 to20fce2cCompareMay 24, 2023 09:57
@thc202thc202 removed their request for reviewMay 24, 2023 11:19
@Keindel
Copy link
Author

Json formatting is excluded, DCO requirement is satisfied.

@KeindelKeindel changed the title[WIP] Breakpoints.Breakpoints.May 25, 2023
@kingthorinkingthorin removed their request for reviewMay 25, 2023 12:14
@kingthorin
Copy link
Member

  • The commits can be squashed or fixed-up, and signed off for DCO.
  • The code formatting should be consistent. It is syntactically correct, and I'm sure there's other old code where things weren't done 'right' but conditionals should use curly braces even for single statements, etc.

@KeindelKeindelforce-pushed thebreaks-pr branch 2 times, most recently from81eda3e toc29db43CompareMay 25, 2023 13:27
@Keindel
Copy link
Author

Keindel commentedMay 25, 2023
edited
Loading

Added null-checks for not yet implemented experimental DB case.
Added instance class checks before DB-related methods call.

New commits are squashed and signed off for DCO.
curly braces even for single statements - fixed

@thc202thc202 removed their request for reviewMay 29, 2023 07:26
@kingthorinkingthorin removed their request for reviewMay 29, 2023 08:44
@Keindel
Copy link
Author

It seems that neglecting of special chars escaping for breaks UI may affect user workflow.
So I've reverted those changes.

@KeindelKeindel requested a review fromkingthorinJune 16, 2023 12:18
Split url string into host+path+query.Add request and/or response choice in breaks.Add break persisting.Signed-off-by: Andrey Maksimov <g.andmaximov@gmail.com>
@Keindel
Copy link
Author

updated header comments

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@thc202thc202Awaiting requested review from thc202

@kingthorinkingthorinAwaiting requested review from kingthorin

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Keindel@kingthorin@thc202

[8]ページ先頭

©2009-2025 Movatter.jp