Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

feat(dialog): add newkeyboardEnabled prop#13178

Merged
chenjiahan merged 5 commits intoyouzan:mainfromlzxiaoqi:fix_dialog_enableKeyboard
Nov 2, 2024

Conversation

lzxiaoqi
Copy link
Contributor

Before submitting a pull request, please read thecontributing guide.

在提交 pull request 之前,请阅读贡献指南

#13164

针对issue#13164 提到的部分手机场景的某些操作会自动执行enter的键盘事件,新增keyboardEnabled属性来控制是否选择使用键盘能力选项

@codecov-commenter
Copy link

codecov-commenter commentedOct 30, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is0% with2 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base(379f44a) to head(d4c26dc).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
packages/vant/src/dialog/Dialog.tsx0.00%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #13178      +/-   ##==========================================- Coverage   89.67%   89.63%   -0.04%==========================================  Files         257      257                Lines        7004     7006       +2       Branches     1732     1733       +1     ==========================================- Hits         6281     6280       -1- Misses        378      382       +4+ Partials      345      344       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Member

@chenjiahanchenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@chenjiahanchenjiahan changed the titlefeat(dialog): The keyboard capability option is available for supportfeat(dialog): add newkeyboardEnabled propNov 2, 2024
@chenjiahanchenjiahanenabled auto-merge (squash)November 2, 2024 04:33
@chenjiahanchenjiahan merged commit5027d22 intoyouzan:mainNov 2, 2024
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chenjiahanchenjiahanchenjiahan approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lzxiaoqi@codecov-commenter@chenjiahan

[8]ページ先頭

©2009-2025 Movatter.jp