- Notifications
You must be signed in to change notification settings - Fork998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: add missing entries to published files#2185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Due to the `yargs.mjs` file not being published, the fix merged withyargs#2151 is not effective yet. This change should fix that.```Cannot find module './node_modules/yargs/yargs.mjs' imported from ./cli.js```
filesfiles This was referencedMay 12, 2022
bcoe approved these changesMay 14, 2022
@hongaar thank you for catching this 👍 aside, what do you think of making yargs ESM only, when we drop Node 12? |
@bcoe reading some articles on the subject, it looks like this will be a breaking change since consuming ESM modules from CJS can't use |
This was referencedSep 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the
yargs.mjsfile not being published, the fix merged with#2151 is not effective yet. This change should fix that.Edit: Also added missing
browser.d.ts