- Notifications
You must be signed in to change notification settings - Fork998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: prevent infinite loop with locale#2179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jly36963 commentedMay 6, 2022
| @@ -871,7 +871,7 @@ export class YargsInstance { | |||
| } | |||
| locale(locale?: string): YargsInstance | string { | |||
| argsert('[string]', [locale], arguments.length); | |||
| if (!locale) { | |||
| if (locale === undefined) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
'' is falsey, and it causes the two functions to infinitely call each other
bcoe approved these changesMay 15, 2022
This was referencedSep 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses:#2178
Description
locale and kGuessLocale can enter an infinite loop
Details
There's regex logic that turns '.UTF-8' into '', and downstream there is logic checking if that value is falsey (instead of undefined).
As a result, kGuessLocale and locale call each other infinitely.
Todo
This line is what converts
'.UTF-8'into''. I don't know if my fix is sufficient or if the real problem is here.