Commitfc914d5

psphicas

authored and

ingydotnet

committed

Avoid repeatedly appending to yaml_implicit_resolvers

Repeated calls to `resolve` can experience performance degredation, if`add_implicit_resolver` has been called with `first=None` (to add animplicit resolver with an unspecified first character).For example, every time `foo` is encountered, the "wildcard implicitresolvers" (with `first=None`) will be appended to the list of implicitresolvers for strings starting with `f`, which will normally be theresolver for booleans. The list `yaml_implicit_resolvers['f']` will keepgetting longer. The same behavior applies for any first-letter matcheswith existing implicit resolvers.This change avoids unintentionally mutating the lists in the class-leveldict `yaml_implicit_resolvers` by looping through a temporary copy.Fixes:#439

1 parenta001f27 commitfc914d5Copy full SHA for fc914d5

File tree

2 files changed

-4

lines changed

lib3/yaml
- resolver.py
lib/yaml
- resolver.py

2 files changed

-4

lines changed

`‎lib/yaml/resolver.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,8 @@ def resolve(self, kind, value, implicit):`
`146`	`146`	`resolvers=self.yaml_implicit_resolvers.get(u'', [])`
`147`	`147`	`else:`
`148`	`148`	`resolvers=self.yaml_implicit_resolvers.get(value[0], [])`
`149`		`-resolvers+=self.yaml_implicit_resolvers.get(None, [])`
`150`		`-fortag,regexpinresolvers:`
	`149`	`+wildcard_resolvers=self.yaml_implicit_resolvers.get(None, [])`
	`150`	`+fortag,regexpinresolvers+wildcard_resolvers:`
`151`	`151`	`ifregexp.match(value):`
`152`	`152`	`returntag`
`153`	`153`	`implicit=implicit[1]`

`‎lib3/yaml/resolver.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,8 @@ def resolve(self, kind, value, implicit):`
`146`	`146`	`resolvers=self.yaml_implicit_resolvers.get('', [])`
`147`	`147`	`else:`
`148`	`148`	`resolvers=self.yaml_implicit_resolvers.get(value[0], [])`
`149`		`-resolvers+=self.yaml_implicit_resolvers.get(None, [])`
`150`		`-fortag,regexpinresolvers:`
	`149`	`+wildcard_resolvers=self.yaml_implicit_resolvers.get(None, [])`
	`150`	`+fortag,regexpinresolvers+wildcard_resolvers:`
`151`	`151`	`ifregexp.match(value):`
`152`	`152`	`returntag`
`153`	`153`	`implicit=implicit[1]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc914d5

File tree

2 files changed

2 files changed

`‎lib/yaml/resolver.py`

`‎lib3/yaml/resolver.py`

0 commit comments