Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork69
Fixes the issue with the missing name attribute default mentioned in #58#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
Namoshek commentedFeb 20, 2018
Note: The |
Owner
yajra commentedFeb 21, 2018
Thanks, released on v3.7.0 🍻 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in#58, there has been an issue where the documentation said that the
nameattribute of columns is set to thedataattribute if not present. This PR fixes this issue for both theBuilder::columns(array $columns)method as well as for theColumn::__construct(array $attr)method.I think the changes are quite straight forward, although I haven't tested them (don't have an easy way to do so on this machine). In theory this should be no breaking change as the behavior can always be overwritten.
There has been no hint which branch we should create PRs for, so I've chosen master. Feel free to ask for another PR if this doesn't work out for you!