Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.0] Moving callback condition to config#54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
yajra merged 2 commits intoyajra:3.0fromlk77:3.0
Jan 11, 2018
Merged

Conversation

@lk77
Copy link
Contributor

Hello,

i have moved the callback condition to config.

see#53 and#49

thanks.

yajra reacted with thumbs up emoji
protectedfunctionisCallbackFunction($value,$key)
{
return Str::startsWith(trim($value), ['$','$.','function']) || Str::contains($key,'editor');
return Str::startsWith(trim($value),config('datatables-html.callback',['$','$.','function'])) || Str::contains($key,'editor');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we can use the config property instead since we already injected it?

$this->config->get('datatables-html.callback', ['$', '$.', 'function'])

@lk77
Copy link
ContributorAuthor

yes, sorry, the config helper call don't even worked, my bad,
i've corrected it.

thanks.

@lk77lk77 changed the titleMoving callback condition to config[3.0] Moving callback condition to configJan 10, 2018
@yajrayajra merged commita39da1d intoyajra:3.0Jan 11, 2018
@yajra
Copy link
Owner

Released on v3.5.2, thanks a lot 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yajrayajrayajra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lk77@yajra

[8]ページ先頭

©2009-2025 Movatter.jp