Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork69
Update Column.php: Rename data method to setData#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Renamed the data method to setData in the Yajra\DataTables\Html\Column class to avoid conflicts with the data method in Illuminate\Support\Fluent
Owner
yajra commentedNov 29, 2024
fixed via#230, thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading.Please reload this page.
This change renames the data method in the Yajra\DataTables\Html\Column class to setData to resolve a method signature conflict with the parent class Illuminate\Support\Fluent.
This conflicts with the data method in the parent Illuminate\Support\Fluent class, which has the signature:
This results in the following PHP error:
Proposed Solution
The data method in the Column class has been renamed to setData to avoid the conflict:
Benefits of the Fix
1.Conflict Resolution: Avoids the signature conflict with Illuminate\Support\Fluent.
2.Clarity: Improves method naming by explicitly reflecting its purpose (setData for setting values).
3.Backward Compatibility: Allows the Column class to coexist with Fluent without breaking functionality.
Additional Notes
•Any existing usage of data() to set column data will need to be updated to setData() in the codebase.
•This change only affects the method used to set column data. The method inherited from Fluent (data($key = null, $default = null)) remains intact for retrieving data.