Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Upgrade graphql-java from 6 to 16.2#3044

Open
wcekan wants to merge3 commits intoelide-4.x
base:elide-4.x
Choose a base branch
Loading
fromgraphql
Open

Conversation

wcekan
Copy link
Contributor

@wcekanwcekan commentedAug 12, 2023•
edited
Loading

Description

Major upgrade of GraphQL Java backported to 4.x
Cherry picked from 5.0.5 PR#2228 with merge conflicts fixed.

Motivation and Context

GraphQL 6 is too old. This will be the first step in getting Elide 4.x to a more recent version of GraphQL.

How Has This Been Tested?

Unit testing. Local testing.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@wcekanwcekan requested a review fromaklishAugust 12, 2023 19:17
@wcekan
Copy link
ContributorAuthor

wcekan commentedAug 12, 2023•
edited
Loading

@aklish any idea about these 2 failures?

Failures:
FetcherFetchTest.testFetchWithFragments:166->runComparisonTest:208->PersistentResourceFetcherTest.runComparisonTest:285->PersistentResourceFetcherTest.runComparisonTest:302->PersistentResourceFetcherTest.assertQueryEquals:192->PersistentResourceFetcherTest.assertQueryEquals:218 author.edges[0].__typename
Expected: _edges__author
got: AuthorEdge
; author.edges[1].__typename
Expected: _edges__author
got: AuthorEdge

ModelBuilderTest.testBuild:143 authorInput ==> expected: not<null>

@moizarafat
Copy link
Collaborator

Overall the changes looked good to me when compared to the original PR.

The test casetestFetchWithFragments which is failing inFetcherFetchTest was removed as part of the below commit and replaced with different test cases though i can not remember why.

9bda018

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aklishaklishAwaiting requested review from aklish

@moizarafatmoizarafatAwaiting requested review from moizarafat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@wcekan@moizarafat@aklish
[8]ページ先頭
©2009-2025 Movatter.jp