- Notifications
You must be signed in to change notification settings - Fork231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Defer inline checks when processing relationships#3040
base:master
Are you sure you want to change the base?
Conversation
I think the build test failure might be transient as I can't seem to replicate the failure of |
restarted the build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See earlier comment in the issue. I don't think we can safely defer inline READ checks for any mutation operations.
Resolves#2986
Description
This defers inline checks in the
ActivePermissionExecutorwhen processing relationships.deferInlineChecksvariable in theRequestScopeActivePermissionExecutorto also take into consideration thedeferInlineChecksvariableJsonApiAtomicOperationsandJsonApiJsonPatchto set defer inline checks to true when post processing relationships.Motivation and Context
Previously it was possible for two separate consecutive updates to succeed but when the same updates were bundled into a atomic operation or json patch request were failing due to permissions checks.
How Has This Been Tested?
Added the appropriate tests.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.