Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork218
use glyphfonts with text delegate#105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xvrh commentedOct 12, 2020
Hi@itslenny, This package is a pure translation of the So, to be honest, I don't known why glyph font are disabled when there is a delegate. If you think it doesn't have side effects. I'm totally ok to remove the check and merge your pull request. |
Uh oh!
There was an error while loading.Please reload this page.
Hi, this should maybe be an "issue" but I needed a fix right away for my own uses so this is my little hack fix. Hoping this can open a discussion. Obviously, I don't expect this to PR to be merged as-is.
In my app I'm using glyph fonts to represent numbers. There are several labels some with words and some with numbers. Two labels display a score to the user which needs to be modified at runtime. In our AE file we include numbers 0-9 to enable the use of glyph fonts for this, but for some reason when the text delegate is used glyph fonts are disabled... why?
Simply adding the text delegates causes all glyphs in the entire animation to break...
This simple PR just re-enables it and adds delegate support to the text_layer code. Works perfectly.
Why were glyph fonts disabled when text delegate is used? How can this be changed to provide the user the option to use font text of glyph font (regardless of if the delegate is used)?
For now we're using this forked version to un-break our app, but I'd love to switch back to your package.