- Notifications
You must be signed in to change notification settings - Fork1.8k
webfonts addon#5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
webfonts addon#5178
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| constpos=s.match(/([-_a-zA-Z0-9\xA0-\u{10FFFF}]+)/u); | ||
| constneg=s.match(/^(-?\d|--)/m); | ||
| if(!neg&&pos&&pos[1]===s)returns; | ||
| return`"${s.replace(/"/g,'\\"')}"`; |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
jerch commentedOct 3, 2024
@Tyriar I am not sure, if the integration testing works correctly atm. There are several tests failing, but the CI does still mark them as successful. 🤔 Example:https://github.com/xtermjs/xterm.js/actions/runs/11170843380/job/31054434727?pr=5178#step:10:491 |
| res.sendFile(__dirname+'/style.css'); | ||
| }); | ||
| app.get('/kongtext.regular.ttf',(req,res)=>res.sendFile(__dirname+'/kongtext.regular.ttf')); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| }); | ||
| app.get('/kongtext.regular.ttf',(req,res)=>res.sendFile(__dirname+'/kongtext.regular.ttf')); | ||
| app.get('/bpdots.regular.otf',(req,res)=>res.sendFile(__dirname+'/bpdots.regular.otf')); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Tyriar commentedOct 4, 2024
Ugh, this again |
Tyriar commentedOct 4, 2024
Will handle in#5179 |
Tyriar commentedOct 4, 2024
Fixed:#5180 |
jerch commentedOct 4, 2024
I have no clue yet, how to test that in the CI. Maybe it is possible to track the font asset loading somehow with playwright. The changing glyph metrics should be spotable though (my demo fonts are quite different from the usual ones). |
jerch commentedOct 4, 2024
@Tyriar Added some CI tests, ready for review. |
Uh oh!
There was an error while loading.Please reload this page.
Since the issue#5164 brought up webfonts once more and the other addon is quite outdated, I started to build a new one.
TODO:
Roboto Monofrom client.ts and client.css again