Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOM Renderer: Render background separately#4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mofux wants to merge3 commits intoxtermjs:master
base:master
Choose a base branch
Loading
frommofux:dom-renderer-bg

Conversation

@mofux
Copy link
Contributor

@mofuxmofux commentedSep 20, 2023
edited
Loading

This PR attempts to resolve clipping issues with the DOM renderer when a cell has a background color set and the rendered character is wider than its cell.

It does so by creating separate spans for backgrounds. These background spans are positioned absolute and are added to the row div before any of the text spans (so the text spans will always be drawn above).

Text spans can now be merged even if the background color differs, so in many scenarios we won't even produce more spans than before.

As a little bonus, the text spans are nowdisplay: inline which should provide a little performance boost and might be beneficial when dealing with ligatures.

TODO

  • Do not create background span if there is no background
  • Remove selection layer and draw it as part of the background
  • Make sure to handle cursor and decorations properly
  • Adjust tests
  • Analyze how performance differs to old DOM renderer

pulnip reacted with eyes emoji
@jerch
Copy link
Member

beneficial when dealing with ligatures.

And BIDI. 😸

@Tyriar
Copy link
Member

This PR attempts to resolve some rendering issues with the DOM renderer when a cell has a background color set.

Can you elaborate on the issues this will fix?

@bmeares
Copy link

Perhaps this will fix the issues with rendering double-width chars (#4813)? Linking for reference

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mofux@jerch@Tyriar@bmeares

[8]ページ先頭

©2009-2025 Movatter.jp