- Notifications
You must be signed in to change notification settings - Fork1.8k
DomRenderer draw selection inactive background correctly when unfocused#4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
DomRenderer draw selection inactive background correctly when unfocused#4763
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There's too many theme colors, we'll leave it to the console
Tyriar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fix works 👍
I reverted the demo parts as there's too many theme keys to do that (though we may add theme customization to the options tab at some point). I did set the default value for the inactive theme key to the default theme though.
Tyriar commentedSep 9, 2023
Added a regression test |
tisilent commentedSep 9, 2023
I also try the playwright test. |
fa1356c toa101135Compare
fix#4750.