- Notifications
You must be signed in to change notification settings - Fork1.8k
remove inwasm burden#4727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
remove inwasm burden#4727
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tyriar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure how to go aboutxterm-wasm-parts - we can move it over into xtermjs group, or leave at my site (hopefully the inwasm patches dont take too long...)
It's fine as is since it's just temporary
jerch commentedAug 25, 2023
Well just give a ping, if it raises security concerns on your end. Then we prolly should put it fully under the xtermjs group umbrella. (e.g. also the npm releasing and such). |
Tyriar commentedAug 25, 2023
We should see any changes to the npm package going in, the only risk should be if the yarn.lock changes |
Uh oh!
There was an error while loading.Please reload this page.
Since
inwasmstill creates too much fuss at various ends, I removed it until it is in better shape.@Tyriar Not sure how to go aboutxterm-wasm-parts - we can move it over into xtermjs group, or leave at my site (hopefully the
inwasmpatches dont take too long...)Fixes#4720,fixes#4646.