Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Parallelize required tests and build jobs#4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tyriar merged 9 commits intoxtermjs:masterfromTyriar:waiton
Aug 22, 2023
Merged

Conversation

@Tyriar
Copy link
Member

@TyriarTyriar commentedAug 22, 2023
edited
Loading

An issue currently is that the Windows tests are by far the slowest which drags everything down. This is mainly because it takes so long to install dependencies:

image

Above time to merge was approximately1m24s + 8m44s = 10m8s

For integration tests the Windows ones are optional since we expect them to rarely fail, so they rely on us to notice. I don't think we should do this for the unit tests though as we want auto merge to be reliable and they're more likely to fail.

This change kicks off the required unit test and integration test jobs immediately and then waits for the build job to finish after installing dependencies, effectively saving up to the build job time (~1m30s) from the required checks. We only do this for the subset of jobs that are marked as required to merge to be a good GH actions citizen and not use agents so eagerly, this should also ensure the required unit test job will get a Windows agent before the optional integration test one.

image

Above time to merge was approximatelymax(1m18s, 6m48s) = 6m48s - probably just got lucky here or unlucky in the top one for the individual job times

@TyriarTyriar self-assigned thisAug 22, 2023
@TyriarTyriar closed thisAug 22, 2023
@TyriarTyriar reopened thisAug 22, 2023
@TyriarTyriar changed the titleTry parallelize tests and buildParallelize required tests and build jobsAug 22, 2023
@TyriarTyriar merged commit94ab565 intoxtermjs:masterAug 22, 2023
@TyriarTyriar added this to the5.3.0 milestoneAug 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@TyriarTyriar

Labels

None yet

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@Tyriar

[8]ページ先頭

©2009-2025 Movatter.jp