- Notifications
You must be signed in to change notification settings - Fork1.8k
Add support for SGR 53 overline and SGR 55 not overline#4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jerch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yet another attribute to look for in the serializer 😱 🤣
LGTM 👍
This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.
About the color:
Imho using FG color is the only useful option atm, underline color is explicitly defined for underline, but we have nothing like that for overline (plz lets not open Pandora's box here and add another color setting for a rarely used attribute).
About overline cutting through glyphs:
Actually this might help to get an easier distinction from underlines above. Also the use cases in the WT thread suggest this as a visual help for things like a status line - here a "hard border/line" cutting through glyphs might help to get the wanted visual separation.
Uh oh!
There was an error while loading.Please reload this page.
Defined inhttps://www.ecma-international.org/publications-and-standards/standards/ecma-48/
Fixes#4499
This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.
dom
canvas
webgl