Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for SGR 53 overline and SGR 55 not overline#4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tyriar merged 2 commits intoxtermjs:masterfromTyriar:4499_overline
May 20, 2023

Conversation

@Tyriar
Copy link
Member

@TyriarTyriar commentedMay 20, 2023
edited
Loading

Defined inhttps://www.ecma-international.org/publications-and-standards/standards/ecma-48/

Fixes#4499

This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.

dom

image

canvas

image

webgl

image

@TyriarTyriar added this to the5.2.0 milestoneMay 20, 2023
@TyriarTyriar requested a review fromjerchMay 20, 2023 17:06
@TyriarTyriar self-assigned thisMay 20, 2023
Copy link
Member

@jerchjerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yet another attribute to look for in the serializer 😱 🤣

LGTM 👍

This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.

About the color:
Imho using FG color is the only useful option atm, underline color is explicitly defined for underline, but we have nothing like that for overline (plz lets not open Pandora's box here and add another color setting for a rarely used attribute).

About overline cutting through glyphs:
Actually this might help to get an easier distinction from underlines above. Also the use cases in the WT thread suggest this as a visual help for things like a status line - here a "hard border/line" cutting through glyphs might help to get the wanted visual separation.

Tyriar reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jerchjerchjerch approved these changes

Assignees

@TyriarTyriar

Labels

None yet

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

Support SGR 53 "overline"

2 participants

@Tyriar@jerch

[8]ページ先頭

©2009-2025 Movatter.jp