- Notifications
You must be signed in to change notification settings - Fork1.8k
Ensure stale bitmap is not used when drawing new characters#4189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This would cause a problem where the first time a glyph is used it wouldnot be visible because it was using the old invalidated bitmap.
Tyriar added a commit to microsoft/vscode that referenced this pull requestOct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpersxtermjs/xterm.js#4195- Improve dotted line for canvasxtermjs/xterm.js#4100- Fix demo againxtermjs/xterm.js#4193- Switch to Ubuntu 20.04xtermjs/xterm.js#4192- Fix clearTextureAtlas call as implemented on IRendererxtermjs/xterm.js#4180- Create theme servicextermjs/xterm.js#4188- Ensure stale bitmap is not used when drawing new charactersxtermjs/xterm.js#4189- Lint rule for on=event emitter and rename all methods with on prefix to handlextermjs/xterm.js#4187- Fix a bunch of memory retention problemsxtermjs/xterm.js#4185
Tyriar added a commit to microsoft/vscode that referenced this pull requestOct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpersxtermjs/xterm.js#4195- Fix demo againxtermjs/xterm.js#4193- Switch to Ubuntu 20.04xtermjs/xterm.js#4192- Fix clearTextureAtlas call as implemented on IRendererxtermjs/xterm.js#4180- Create theme servicextermjs/xterm.js#4188- Ensure stale bitmap is not used when drawing new charactersxtermjs/xterm.js#4189- Lint rule for on=event emitter and rename all methods with on prefix to handlextermjs/xterm.js#4187- Fix a bunch of memory retention problemsxtermjs/xterm.js#4185
lemanschik pushed a commit to code-oss-dev/code that referenced this pull requestNov 25, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpersxtermjs/xterm.js#4195- Fix demo againxtermjs/xterm.js#4193- Switch to Ubuntu 20.04xtermjs/xterm.js#4192- Fix clearTextureAtlas call as implemented on IRendererxtermjs/xterm.js#4180- Create theme servicextermjs/xterm.js#4188- Ensure stale bitmap is not used when drawing new charactersxtermjs/xterm.js#4189- Lint rule for on=event emitter and rename all methods with on prefix to handlextermjs/xterm.js#4187- Fix a bunch of memory retention problemsxtermjs/xterm.js#4185
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would cause a problem where the first time a glyph is used it would not be visible because it was using the old invalidated bitmap.