Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert "Merge pull request #4166 from Tyriar/event_with_emitter"#4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tyriar merged 1 commit intoxtermjs:masterfromTyriar:tyriar/revert_events
Oct 6, 2022

Conversation

@Tyriar
Copy link
Member

This reverts commitd22f7c9, reversing changes made to1f8e6f0.

When discussed with the VS Code team they pointed out this is a bit dangerous exposing the emitters publicly everywhere. Reverting as I was convinced safety beats convenience.

@TyriarTyriar added this to the5.1.0 milestoneOct 6, 2022
@TyriarTyriar self-assigned thisOct 6, 2022
@TyriarTyriarenabled auto-mergeOctober 6, 2022 16:51
@TyriarTyriar merged commit3ec0894 intoxtermjs:masterOct 6, 2022
@TyriarTyriar deleted the tyriar/revert_events branchOctober 6, 2022 17:18
@jerch
Copy link
Member

@Tyriar How is that more dangerous than the current approach? I mean a serious attacker can just follow the internal symbols to get down to the emitters anyway? (Btw thats basically what I did during the listener debugging to get a hold if their root...)

@Tyriar
Copy link
MemberAuthor

It's not a security issue, but a separation of concerns issue. The risk is too great that some commit would be made that creates an instance of a class class but not assign it to a variable typed with the interface (not the class) which would expose fire.

jerch reacted with thumbs up emoji

@jerch
Copy link
Member

Ah ok, yeah this newer approach mixed functionality into one thingy, that needs a certain usage pattern. I tend to treat those things as "if in doubt: explicit is better than implicit".

Tyriar reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@TyriarTyriar

Labels

None yet

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar@jerch

[8]ページ先頭

©2009-2025 Movatter.jp