- Notifications
You must be signed in to change notification settings - Fork1.8k
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"#4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jerch commentedOct 6, 2022
@Tyriar How is that more dangerous than the current approach? I mean a serious attacker can just follow the internal symbols to get down to the emitters anyway? (Btw thats basically what I did during the listener debugging to get a hold if their root...) |
Tyriar commentedOct 6, 2022
It's not a security issue, but a separation of concerns issue. The risk is too great that some commit would be made that creates an instance of a class class but not assign it to a variable typed with the interface (not the class) which would expose fire. |
jerch commentedOct 6, 2022
Ah ok, yeah this newer approach mixed functionality into one thingy, that needs a certain usage pattern. I tend to treat those things as "if in doubt: explicit is better than implicit". |
This reverts commitd22f7c9, reversing changes made to1f8e6f0.
When discussed with the VS Code team they pointed out this is a bit dangerous exposing the emitters publicly everywhere. Reverting as I was convinced safety beats convenience.