Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

exclude powerline chars from min contrast for webgl and dom#3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
meganrogge merged 2 commits intoxtermjs:masterfrommeganrogge:merogge/contrast
Apr 20, 2022

Conversation

@meganrogge
Copy link
Member

@meganroggemeganrogge commentedApr 20, 2022
edited
Loading

@meganroggemeganrogge requested a review fromjerchApril 20, 2022 00:44
@meganroggemeganrogge merged commit38f0dd9 intoxtermjs:masterApr 20, 2022
@jerch
Copy link
Member

@meganrogge Just a minor headsup - the webgl code considers a smaller codepoint range to be powerline glyphs:https://github.com/meganrogge/xterm.js/blob/341ca24dda672475f683eaf8f0ff6318e3143513/addons/xterm-addon-webgl/src/atlas/WebglCharAtlas.ts#L379

Is this intended? (If not, maybe the check should be coded in one central place to avoid incongruence?)

meganrogge reacted with thumbs up emoji

@meganrogge
Copy link
MemberAuthor

Yes I was wondering about that, but not sure. I might wait until@Tyriar is back to make further changes. Sound good?

@meganrogge
Copy link
MemberAuthor

Actually, should probably just be consistent. Will do

@jerch
Copy link
Member

Yes I was wondering about that, but not sure. I might wait until@Tyriar is back to make further changes. Sound good?

Actually, should probably just be consistent. Will do

Well I dont mind, whatever suits your plans. My first reflex would be consistency over code repetitions, but I dont know if the webgl code has the smaller range for a good but non-obvious reason. Maybe go the consistency route in the first place, and introduce a special case in webgl code later, if@Tyriar had a specific reason for the smaller range?

meganrogge reacted with thumbs up emoji

@meganroggemeganrogge self-assigned thisApr 22, 2022
@meganroggemeganrogge added this to the4.19.0 milestoneApr 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jerchjerchAwaiting requested review from jerch

Assignees

@meganroggemeganrogge

Labels

None yet

Projects

None yet

Milestone

4.19.0

Development

Successfully merging this pull request may close these issues.

exclude powerline chars from min contrast ratio for webgl and dom renderers

2 participants

@meganrogge@jerch

[8]ページ先頭

©2009-2025 Movatter.jp