Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix_libc++_cannot_find_stdmodule#7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SnowinterCat wants to merge3 commits intoxmake-io:dev
base:dev
Choose a base branch
Loading
fromSnowinterCat:dev

Conversation

@SnowinterCat
Copy link

fix#7073

  • 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
  • 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@SnowinterCat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Xmake failed to locatelibc++std modules, specifically when theclang compiler path was a symbolic link. It introduces a new function to robustly resolve symbolic links, which is then used to correctly determine thestd module directory, thereby enhancing the reliability of C++ module support within Xmake.

Highlights

  • Symbolic Link Resolution: Introduced a new utility function,parse_link_files, to accurately resolve symbolic links to their canonical target paths.
  • Improvedstd Module Discovery: Modified theget_stdmodules function to leverage the newparse_link_files utility, ensuring correct identification of thestd module directory even when theclang executable path is a symbolic link.
  • Fix forlibc++ Module Loading: Addresses an issue wherelibc++std modules could not be found, particularly in environments where theclang compiler is accessed via a symbolic link, by correctly resolving the compiler's true location.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request aims to fix an issue with locating libc++ standard modules by introducing a helper functionparse_link_files to resolve symbolic links. However, the implementation ofparse_link_files is incomplete as it doesn't handle chained symbolic links, a common scenario on Linux systems. Additionally, the logic for resolving module paths has been changed to be relative to the clang executable's directory, which contradicts LLVM's documentation and is likely incorrect. I have provided suggestions to address both of these issues to ensure robust and correct behavior.

@waruqiwaruqi requested a review fromArthapzNovember 28, 2025 06:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ArthapzArthapzAwaiting requested review from Arthapz

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The module support file for libc++ cannot be found.

1 participant

@SnowinterCat
[8]ページ先頭
©2009-2025 Movatter.jp