Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork888
Addbuild.link_target_with_fullpath policy to attempt to link target with full path#7011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello@waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Xmake's linking capabilities by introducing a new policy, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request introduces a new policybuild.link_target_with_fullpath to control whether to use full paths when linking target dependencies, which is a useful feature for avoiding link conflicts. The implementation is generally good, but I have identified a minor bug in the linker detection logic and a couple of areas where the code could be simplified for better readability and maintainability. My review includes specific suggestions to address these points.
| iftarget:policy("build.link_target_with_fullpath")andtarget:has_tool("ld","gxx","clangxx","link")then | ||
| link_filepath=true | ||
| end | ||
| link_filepath=link_filepathorfalse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The logic here can be simplified for better readability. Also, the call totarget:has_tool is missing"ld" from the list of tools to check. This means if the linker isld,has_tool will returnfalse, which is likely not the intended behavior.
I suggest refactoring this block to fix the bug and make the logic clearer.
if target:policy("build.link_target_with_fullpath") and target:has_tool("ld", "ld", "gxx", "clangxx", "link") then link_filepath = true else link_filepath = false end| iftarget_utils.can_link_fullpath(target)then | ||
| link_filepath=true | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thisif block can be simplified to a direct assignment, sincetarget_utils.can_link_fullpath(target) already returns a boolean value. This makes the code more concise.
link_filepath = target_utils.can_link_fullpath(target)
#7000