Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(llvm) Improve runenvs for llvm and clang toolchain#6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Arthapz wants to merge7 commits intoxmake-io:dev
base:dev
Choose a base branch
Loading
fromArthapz:fix-compiler-rt

Conversation

@Arthapz
Copy link
Member

@ArthapzArthapz commentedNov 1, 2025•
edited
Loading

This PR enable the usage of sanitizers on windows without manual DLL copy or PATH setting with llvm and clang toolchains

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@Arthapz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical linking issues for LLVM-based projects on Windows, specifically concerningcompiler-rt builtins andlibc++ libraries. It introduces robust mechanisms forxmake to correctly locate and link these components, ensuring proper compilation and execution. A new dedicated test case has been added to validate these fixes.

Highlights

  • New LLVM Compiler-RT Test: A new test projectllvm_compiler_rt has been added, includingmain.c which uses__int128 to verifycompiler-rt builtins, andtest.lua to automate its build and execution with the LLVM toolchain onxmake.
  • Enhanced LLVM Path Detection: New functions like_get_llvm_resourcedir and_get_llvm_compiler_win_rtdir_and_link were introduced inxmake/modules/core/tools/clang.lua to improve the detection of LLVM's resource, root, andcompiler-rt library directories, particularly for Windows environments.
  • Explicit Windows LLVM Linker Fixes: Thenf_runtime function inxmake/modules/core/tools/clang.lua now explicitly manageslibc++ include paths and forces the linking ofcompiler-rt builtins on Windows, addressing known issues with automatic linking in LLVM on this platform.
  • Expanded Compiler Runtime Tool Support: Thecompiler_runtime rule inxmake/rules/utils/compiler_runtime/xmake.lua has been updated to recognizeclang as a valid compiler when determining and applying default Visual Studio runtimes on Windows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request effectively addresses the issue of linking LLVM compiler runtime builtins on Windows. The changes are well-structured, introducing a new test case to validate the fix and refactoring the LLVM path discovery logic for better clarity and maintainability. The core of the fix, which involves correctly identifying the compiler-rt library and passing the necessary flags to the compiler and linker, appears to be sound. I've added a couple of minor comments regarding code style and indentation to align with the project's conventions.

@ArthapzArthapz marked this pull request as draftNovember 1, 2025 23:14
@ArthapzArthapz marked this pull request as ready for reviewNovember 4, 2025 09:27
@ArthapzArthapz marked this pull request as draftNovember 4, 2025 09:34
@ArthapzArthapzforce-pushed thefix-compiler-rt branch 10 times, most recently from108ba9b to93386a9CompareNovember 6, 2025 16:46
@ArthapzArthapz marked this pull request as ready for reviewNovember 6, 2025 18:44
@ArthapzArthapz marked this pull request as draftNovember 7, 2025 18:47
@ArthapzArthapz changed the titlefix(llvm) Fix compiler rt builtins on windowsfix(llvm) Improve runenvs for llvm and clang toolchainNov 7, 2025
@ArthapzArthapzforce-pushed thefix-compiler-rt branch 3 times, most recently frome0507a2 to8f318f5CompareNovember 7, 2025 21:01
@ArthapzArthapz marked this pull request as ready for reviewNovember 7, 2025 22:29
@ArthapzArthapz marked this pull request as draftNovember 8, 2025 15:27
@ArthapzArthapzforce-pushed thefix-compiler-rt branch 4 times, most recently from6bb8b2f to5bbef7dCompareNovember 13, 2025 15:10
@ArthapzArthapz marked this pull request as ready for reviewNovember 13, 2025 16:01
@ArthapzArthapz marked this pull request as draftNovember 21, 2025 13:24
@Arthapz
Copy link
MemberAuthor

i don't have much time currently, i'll fix the pr when possible

@ArthapzArthapz marked this pull request as ready for reviewNovember 26, 2025 14:30
import("core.project.config")
import("core.base.semver")
import("core.tool.linker")
import("core.tool.toolchain", {alias="_toolchain"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rename to core_toolchain

sandbox_core_tool_toolchain.apis=toolchain.apis
sandbox_core_tool_toolchain.directories=toolchain.directories
sandbox_core_tool_toolchain.save=toolchain.save
sandbox_core_tool_toolchain.memcache=toolchain.memcache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we need not to add it. only add a instace api.toolchain:memcache()

like this

function_instance:_memcache()


-- get llvm sdk resource directory
function_get_llvm_resourcedir(toolchain)
localmemcache=_toolchain.memcache()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we can usetoolchain:memcache()

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@waruqiwaruqiwaruqi left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arthapz@waruqi
[8]ページ先頭
©2009-2025 Movatter.jp